Open
Conversation
Only used a bit of basic c++17 to pull some of the crud out of tuple. Now uses overload resolution for get rather than template instantiation.
rhornung67
reviewed
Dec 9, 2021
rhornung67
requested changes
Dec 9, 2021
Member
rhornung67
left a comment
rhornung67
left a comment
There was a problem hiding this comment.
fix issue with c++ standard message for CMake.
Co-authored-by: Rich Hornung <hornung1@llnl.gov>
rhornung67
approved these changes
Dec 10, 2021
Collaborator
|
Can This be closed? - Just saw this PR, probably could have been helpful when I attempted this update a few months back.. whoopsies! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only used a bit of basic c++17 to pull some of the crud out of tuple.
Now uses overload resolution for get rather than template instantiation.